feat(examples): add p/moul/collection #3321
Conversation
github-actions
bot
added
the
🧾 package/realm
🛠 PR Checks Summary🔴 The pull request head branch must be up-to-date with its base (more info) Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🔴 The pull request head branch must be up-to-date with its base (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
moul
force-pushed
the
dev/moul/avlindex
branch
from
1fb34a6 to
630e8f3
Compare
github-actions
bot
added
📦 🤖 gnovm
Signed-off-by: moul <[email protected]>
moul
force-pushed
the
dev/moul/avlindex
branch
from
630e8f3 to
887c1f0
Compare
moul
changed the title
Signed-off-by: moul <[email protected]>
moul
force-pushed
the
dev/moul/avlindex
branch
from
fd8645c to
55ce510
Compare
moul
requested review from
leohhhn,
ajnavarro,
thehowl,
notJoon and
zivkovicmilos
| newKey, ok := safeGenerateKey(idx.fn, obj) | ||
| if !ok { | ||
| // Rollback: restore old object | ||
| c.indexes[IDIndex].tree.Set(idStr, oldObj) | ||
| return 0 | ||
| } |
There was a problem hiding this comment.
When rollback occurs due to safeGenerateKey call failures or UniqueIndex conflicts, only the _id index of oldObj is currently being restored.
I didn't found a mechanism to restore previously removed entries in other indices. This can lead to inconsistency between the _id index and other indices, may potentially compromising data integrity.
| idx.tree.Remove(idStr) | ||
| continue | ||
| } | ||
| key := idx.fn(obj) |
There was a problem hiding this comment.
In the Set function, when inserting data with the CaseInsensitiveIndex option enabled, keys are stored after being converted to lowercase.
if idx.options&CaseInsensitiveIndex != 0 {
key = strings.ToLower(key)
}However, it seems that the same processing is missing when removing these keys in the Delete or Update functions.
In this line, the code attempts to directly delete the key obtained from idx.fn(obj) without any coversion process. I think this can lead to a unexpected behaviour which delection or updates don't work properly because the key doesn't match the actual lowercase key stored in the index.
Addresses #1467
Related with #3317